Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for gcc @file options #65

Merged
merged 1 commit into from
Jan 30, 2017
Merged

Conversation

alexcrichton
Copy link
Contributor

This commit adds support for the @file option that gcc/clang supports. This
option means that an file should be read and @file should be replaced with
all the options specified in file.

The online documentation indicates that gcc supports arguments with spaces
through quoting, but this seemed like it may be nontrivial to implement, so I
figured that for now those cases could continue to be un-cacheable.

Closes #43

This commit adds support for the `@file` option that gcc/clang supports. This
option means that an `file` should be read and `@file` should be replaced with
all the options specified in `file`.

The online documentation indicates that gcc supports arguments with spaces
through quoting, but this seemed like it may be nontrivial to implement, so I
figured that for now those cases could continue to be un-cacheable.

Closes mozilla#43
@luser
Copy link
Contributor

luser commented Jan 30, 2017

Thanks for the patch! MSVC also supports @file, it would be nice to add that in a followup. One difference is that the GCC docs explicitly state that recursive use of @ is OK, but the MSVC docs explicitly say it's not. It's not likely to be a problem in practice since I doubt anyone would be using a construct like that.

@luser luser merged commit 2b60052 into mozilla:master Jan 30, 2017
@alexcrichton alexcrichton deleted the at-files branch January 30, 2017 16:58
crystalin pushed a commit to PureStake/sccache that referenced this pull request Jul 2, 2021
docs: document all config options, includes a unit test for verification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants