Fix clippy warnings with new version of clippy #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_wraps Partially based upon patch from Michael Woerister <michaelwoerister@posteo>.
This will allow PRs with failed CI just because they happened with a newer version of rustfmt/clippy than last time the master branch was checked.
mitchhentges
approved these changes
Mar 10, 2021
| @@ -47,6 +47,7 @@ fn get_file_mode(file: &fs::File) -> Result<Option<u32>> { | |||
| } | |||
|
|
|||
| #[cfg(windows)] | |||
| #[allow(clippy::unnecessary_wraps)] | |||
There was a problem hiding this comment.
Smells like an impl Trait is needed around here, but that's unrelated to this patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants
https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_wraps
Partially based upon patch from Michael Woerister michaelwoerister@posteo in #952.