This repository has been archived by the owner on May 22, 2021. It is now read-only.
UX Refine WIP #302
Merged
UX Refine WIP #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdehaan
reviewed
Jul 25, 2017
views/layouts/main.handlebars
Outdated
| <script defer src="/l20n.min.js"></script> | ||
| </head> | ||
| <body> | ||
| <header class="header"> | ||
| <div class="send-logo"> | ||
| <img src="/resources/send_logo.svg" alt="Send"/> | ||
| <h1 class="site-title">Send</h1> | ||
| <a href="./"> |
There was a problem hiding this comment.
Nit: Can we just use "/" here?
Not sure if a leading zero will cause future issues if we ever do a nested directory structure for some reason.
There was a problem hiding this comment.
Sure, should work the same.
ericawright
suggested changes
Jul 25, 2017
public/main.css
Outdated
| @@ -615,7 +678,7 @@ tbody { | |||
| margin-bottom: -5px; | |||
| } | |||
|
|
|||
| @media (max-device-width: 768px) { | |||
| @media (max-width: 768px) { | |||
There was a problem hiding this comment.
this needs both rules @media (max-device-width: 768px), (max-width: 768px). And the one below too.
max-device-width takes care of phones and devices with different pixel densities. And max-width takes care of when you resize your browser on desktop.
There was a problem hiding this comment.
I was testing the desktop version, forgot to add the device part back!
fix media queries
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UX Refine WIP
Done:
Todo: