This repository has been archived by the owner on May 22, 2021. It is now read-only.
Add link to FAQ in unsupported view #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flodolo
approved these changes
Aug 3, 2017
ericawright
reviewed
Aug 3, 2017
views/unsupported.handlebars
Outdated
| @@ -8,6 +8,7 @@ | |||
| </a> | |||
| {{else}} | |||
| <div class="description" data-l10n-id="notSupportedDetail">Unfortunately this browser does not support the web technology that powers Firefox Send. You’ll need to try another browser. We recommend Firefox!</div> | |||
| <div class="description"><a href="https://github.com/mozilla/send/blob/master/docs/faq.md#why-is-my-browser-not-supported" data-l10n-id="notSupportedLink" target="_blank" rel="noopener noreferrer"></a></div> | |||
There was a problem hiding this comment.
Can we put the English string inside the a-tags for IE
There was a problem hiding this comment.
Absolutely...
Warning, the combination of <noscript> on the /unsupported/* route looks terrible (mostly entirely due to the fact my noscript hack doesn't seemingly conform to any style guide in the known universe).
ericawright
approved these changes
Aug 3, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just adds a link to the relevant FAQ bits, although we still incur an l10n hit since I had to add a string.
Totally looks like:
Fixes #377