This repository has been archived by the owner on May 22, 2021. It is now read-only.
changed to handle 404 during download, also removing progress listene… #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r once percent completion is 100 to avoid manipulating DOM twice
pdehaan
reviewed
Jun 2, 2017
| @@ -20,6 +20,11 @@ class FileReceiver extends EventEmitter { | |||
| }; | |||
|
|
|||
| xhr.onload = function(e) { | |||
|
|
|||
| if (xhr.status === 404) { | |||
| reject(new Error('The file has expired, or has already been deleted.')); | |||
There was a problem hiding this comment.
Does this need a return statement to prevent leaking into the code path(s) below?
There was a problem hiding this comment.
yes, good catch @pdehaan
There was a problem hiding this comment.
added the return
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r once percent completion is 100 to avoid manipulating DOM twice