Skip to content

Conversation

@hildjj
Copy link
Contributor

@hildjj hildjj commented May 28, 2018

This was the only glaring async fix that I found. Note the latest webpack, the needed addition of webpack-cli, and the addition of "production" mode to webpack.config.js.

@coveralls
Copy link

coveralls commented May 28, 2018

Pull Request Test Coverage Report for Build 489

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 84.119%

Totals Coverage Status
Change from base Build 486: 0.02%
Covered Lines: 908
Relevant Lines: 1049

💛 - Coveralls

Copy link
Contributor

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fitzgen fitzgen merged commit 4cd8239 into mozilla:master May 29, 2018
@hildjj hildjj deleted the async branch June 1, 2018 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants