-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix an off-by-1 error in section lookup #507
Conversation
27daf1a
to
86db47b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this patch. Apologies for the delay in reviews. It looks great! I've got a few review comments.
86db47b
to
3789341
Compare
Thanks for the suggestions! I've updated the patch now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates. LGTM!
In an indexed map, the offset line & column are stored 1-based. However, the lookup for originalPositionFor was not incrementing the 0-based column from the API argument.
3789341
to
79aa958
Compare
There was a linter failure in CI, but should be fixed now (looks like the CI might need approval again to run). |
This should fix issue #506.