Fixes #104

[jinankjain]

@claudijd How about this one?

[claudijd]

This isn't exactly what I was going for here, although this is a step in the right direction.

You could also achieve the same result with KeyExchangeInit because it's a bindata object class type....

default_key_init = SSHScan::KeyExchangeInit.read("...binary...data...")

What I was striving for on this was to build the object piece by piece attribute by attribute...

default_key_init = SSHScan::KeyExchangeInit.new()
default_key_init.macs = blah
default_key_init.encryption = blah
....

[claudijd]

The reasoning here was mainly to be more transparent about what we're actually sending so if someone runs into a bug or compatability thing they can tell us something like "... hey I noticed you only include these ciphers, maybe you should add XYZ?" this I think is better.

[jinankjain]

@claudijd I am trying to print all those properties which we need to set, but it is kind of printing some garbage value so I am not able to get the values of all the properties

[claudijd]

@jinankjain we may need to add some writer functionality to the class so it can be stood up manually. I good place to start would be to do so here in the unit-tests => https://github.com/mozilla/ssh_scan/blob/master/spec/ssh_scan/protocol_spec.rb

[jinankjain]

@claudijd We can have some setter function in that class for setting these parameters manually

[claudijd]

@jinankjain yeah, that's the plan. Bindata allows some of this to be set manually by default, but fields like length/etc. may need to be adapted as dynamic fields while building by using lambda functions.

[claudijd]

@jinankjain would you like me to take a swing at this? I have some time now to take a peek.

[jinankjain]

@claudijd Yeah I am kind of busy this week with some deadlines. It would be good if you could finish this before me.