Added SSH version as a policy control. Fixes #154 #176
Conversation
|
@yashmehrotra please feel free to add 2.0 to modern and intermediate policies here in this PR => https://github.com/mozilla/ssh_scan/tree/master/policies |
|
@yashmehrotra also, feel free to join us in Glitter chat if you'd like. I'd invite you directly, but don't have your email (https://gitter.im/mozilla-ssh_scan/Lobby?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge) |
| end | ||
| end | ||
| return false | ||
| end |
There was a problem hiding this comment.
Returning false or string is a bit weird here.
Maybe we need to improve terminology here.
Maybe there is a method that returns true/false, one that returns the version we saw, and one that returns the version we want? I feel like that might be a little more deliberate.
Also updated mozilla policies for minimum ssh_version
|
@claudijd Hi, I used a new approach, where the function that checks the minimum ssh version only returns a boolean. I hope its good. |
|
@yashmehrotra thanks! |
We just need to add
ssh_version: <minimum>to theymlfile.