Skip to content
This repository has been archived by the owner on Jan 24, 2022. It is now read-only.

Add coveralls #314

Merged
merged 1 commit into from
Jan 12, 2017
Merged

Add coveralls #314

merged 1 commit into from
Jan 12, 2017

Conversation

hvardhanx
Copy link
Collaborator

No description provided.

@hvardhanx hvardhanx merged commit b81c976 into mozilla:master Jan 12, 2017
@hvardhanx hvardhanx mentioned this pull request Jan 12, 2017
@rishabhs95
Copy link
Collaborator

Did you test this feature? I tried earlier and I think there was a problem with integrating coveralls this way, because we have multiple travis tests(matrix) running simultaneously which doesn't provide the accurate coverage report.

@hvardhanx
Copy link
Collaborator Author

hvardhanx commented Jan 12, 2017

Oh. I was trying this today. You can checkout the new PR here: #316
Yeah, that's why I reverted the merge.

@rishabhs95
Copy link
Collaborator

Oh, okay. I'd be really happy to land test coverage on ssh_scan as it will really boost us for better test coverage.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants