Skip to content
This repository has been archived by the owner on Jan 24, 2022. It is now read-only.

Testing coveralls #318

Merged
merged 6 commits into from
Jan 12, 2017
Merged

Testing coveralls #318

merged 6 commits into from
Jan 12, 2017

Conversation

hvardhanx
Copy link
Collaborator

@hvardhanx hvardhanx commented Jan 12, 2017

Testing coveralls.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 48ff09e on royalharsh:test_coveralls into ** on mozilla:master**.

4 similar comments
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 48ff09e on royalharsh:test_coveralls into ** on mozilla:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 48ff09e on royalharsh:test_coveralls into ** on mozilla:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 48ff09e on royalharsh:test_coveralls into ** on mozilla:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 48ff09e on royalharsh:test_coveralls into ** on mozilla:master**.

@rishabhs95
Copy link
Collaborator

Is coveralls posting the correct coverage report here?
I think it's not summarizing the report, rather it is posting for every matrix component.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling ebc44bf on royalharsh:test_coveralls into ** on mozilla:master**.

4 similar comments
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling ebc44bf on royalharsh:test_coveralls into ** on mozilla:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling ebc44bf on royalharsh:test_coveralls into ** on mozilla:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling ebc44bf on royalharsh:test_coveralls into ** on mozilla:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling ebc44bf on royalharsh:test_coveralls into ** on mozilla:master**.

@rishabhs95 rishabhs95 changed the title Update readme Testing coveralls Jan 12, 2017
@hvardhanx
Copy link
Collaborator Author

Yeah, it is posting for every matrix component. But, the coverage is correct.

@rishabhs95
Copy link
Collaborator

Yeah, I meant is it right to post 5 individual posts for every push?
The readme tag will work right but PR should only get 1 coverall comment.

@hvardhanx
Copy link
Collaborator Author

I know it's a bit noisy. One thing we can do is that we can run coveralls only on one version of ruby. Another thing we can do is that we can turn off commenting on pull requests.

@rishabhs95
Copy link
Collaborator

Yeah, I think checking coverage on the latest ruby version should work as if the tests are passing coverage won't depend upon the ruby version.

@claudijd
Copy link
Contributor

@rishabhs95 I agree with the latest ruby approach, I think commenting, assuming it's only one comment per push is acceptable noise level. Nice work here!

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling a163ba5 on royalharsh:test_coveralls into ** on mozilla:master**.

1 similar comment
@coveralls
Copy link

coveralls commented Jan 12, 2017

Coverage Status

Changes Unknown when pulling a163ba5 on royalharsh:test_coveralls into ** on mozilla:master**.

@coveralls
Copy link

coveralls commented Jan 12, 2017

Coverage Status

Changes Unknown when pulling fbfbaca on royalharsh:test_coveralls into ** on mozilla:master**.

1 similar comment
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling fbfbaca on royalharsh:test_coveralls into ** on mozilla:master**.

@claudijd claudijd merged commit fbfbaca into mozilla:master Jan 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants