-
Notifications
You must be signed in to change notification settings - Fork 103
Conversation
Changes Unknown when pulling 48ff09e on royalharsh:test_coveralls into ** on mozilla:master**. |
4 similar comments
Changes Unknown when pulling 48ff09e on royalharsh:test_coveralls into ** on mozilla:master**. |
Changes Unknown when pulling 48ff09e on royalharsh:test_coveralls into ** on mozilla:master**. |
Changes Unknown when pulling 48ff09e on royalharsh:test_coveralls into ** on mozilla:master**. |
Changes Unknown when pulling 48ff09e on royalharsh:test_coveralls into ** on mozilla:master**. |
Is coveralls posting the correct coverage report here? |
Changes Unknown when pulling ebc44bf on royalharsh:test_coveralls into ** on mozilla:master**. |
4 similar comments
Changes Unknown when pulling ebc44bf on royalharsh:test_coveralls into ** on mozilla:master**. |
Changes Unknown when pulling ebc44bf on royalharsh:test_coveralls into ** on mozilla:master**. |
Changes Unknown when pulling ebc44bf on royalharsh:test_coveralls into ** on mozilla:master**. |
Changes Unknown when pulling ebc44bf on royalharsh:test_coveralls into ** on mozilla:master**. |
Yeah, it is posting for every matrix component. But, the coverage is correct. |
Yeah, I meant is it right to post 5 individual posts for every push? |
I know it's a bit noisy. One thing we can do is that we can run coveralls only on one version of ruby. Another thing we can do is that we can turn off commenting on pull requests. |
Yeah, I think checking coverage on the latest ruby version should work as if the tests are passing coverage won't depend upon the ruby version. |
@rishabhs95 I agree with the latest ruby approach, I think commenting, assuming it's only one comment per push is acceptable noise level. Nice work here! |
Changes Unknown when pulling a163ba5 on royalharsh:test_coveralls into ** on mozilla:master**. |
1 similar comment
Changes Unknown when pulling a163ba5 on royalharsh:test_coveralls into ** on mozilla:master**. |
Changes Unknown when pulling fbfbaca on royalharsh:test_coveralls into ** on mozilla:master**. |
1 similar comment
Changes Unknown when pulling fbfbaca on royalharsh:test_coveralls into ** on mozilla:master**. |
Testing coveralls.