Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate GitHub issues in activities.json #1099

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Deduplicate GitHub issues in activities.json #1099

merged 2 commits into from
Oct 21, 2024

Conversation

zcorpan
Copy link
Member

@zcorpan zcorpan commented Oct 15, 2024

Fixes #1087

Copy link
Member

@tantek tantek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mozPositionIssue updates all look correct (and finer-grained) to me. Thanks for doing this.

The only nit I noticed (unchanged from before, but worth fixing while touching these since separate issues with descriptions got created) is a couple of instances of:

"mozPositionDetail": "A welcome successor to XBL!",

Could these be replaced with something slightly more specific to the technology being reviewed? (just as the issue numbers are more specific now)

@zcorpan
Copy link
Member Author

zcorpan commented Oct 16, 2024

What should they say?

@smaug----
Copy link
Collaborator

Maybe "Standardized successor of XBL" would be enough?

(Custom elements and Shadow tree aren't really better than XBL, but there is at least good specifications for both.)

Copy link
Member

@tantek tantek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would have preferred text particular to each spec (like what does it provide that replaces what XBL functionality) but better to land this clean up and improve that later.

@zcorpan zcorpan merged commit 4f06e20 into main Oct 21, 2024
1 check passed
@zcorpan zcorpan deleted the zcorpan/dedupe branch October 21, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use separate issues for separate standards positions
3 participants