Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Feature Policy position #226

Merged
merged 2 commits into from
Nov 27, 2019
Merged

Update the Feature Policy position #226

merged 2 commits into from
Nov 27, 2019

Conversation

annevk
Copy link
Contributor

@annevk annevk commented Nov 21, 2019

As well as an editorial change.

Given that Feature Policy overall is still in flux I suspect we want to keep #24 open though.

@annevk annevk requested a review from dbaron November 21, 2019 13:37
Copy link
Contributor

@dbaron dbaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, although maybe it's worth still mentioning the point that this allows evolution in the defaults (at least for future specifications)? Or does it not do that anymore?

Also, github's diff viewer is pretty bad at showing what's going on with the space-removal changes. (It highlights the spaces on some lines but highlights nothing on other changed lines...)

@annevk
Copy link
Contributor Author

annevk commented Nov 27, 2019

Flipping the defaults is no longer the plan for Feature Policy. At least the way we want to use this is for enabling things we restrict in third-party contexts by default. If we already allow them we wouldn't add a corresponding feature policy identifier.

@annevk annevk merged commit fc6d2eb into master Nov 27, 2019
@annevk annevk deleted the annevk/fp branch November 27, 2019 12:56
@martinthomson martinthomson mentioned this pull request Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants