Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Declarative Shadow DOM (non-harmful) #461

Merged
merged 3 commits into from
Dec 7, 2020
Merged

Add Declarative Shadow DOM (non-harmful) #461

merged 3 commits into from
Dec 7, 2020

Conversation

annevk
Copy link
Contributor

@annevk annevk commented Dec 7, 2020

Closes #335.

martinthomson
martinthomson reviewed Dec 7, 2020
View reviewed changes
Copy link
Member

@martinthomson martinthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems pretty negative. I think that your "the proposal is a reasonable approach given the various constraints" is probably needed to avoid creating the impression that this was misclassified from harmful.

@annevk
Copy link
Contributor Author

annevk commented Dec 7, 2020

Right you are, pushed.

martinthomson
martinthomson approved these changes Dec 7, 2020
View reviewed changes
activities.json Outdated
"mdnUrl": null,
"mozBugUrl": null,
"mozPosition": "non-harmful",
"mozPositionDetail": "We're not convinced that the complexity this feature introduces upon the HTML parser carries its weight in terms of usefulness for web developers. There's also a risk that the processing model is not compatible with a future declarative custom elements feature as it was developed in isolation. Having said that, the proposal is a reasonable approach for this functionality that takes into account the various constrains and security considerations that come with changing the HTML parser.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"mozPositionDetail": "We're not convinced that the complexity this feature introduces upon the HTML parser carries its weight in terms of usefulness for web developers. There's also a risk that the processing model is not compatible with a future declarative custom elements feature as it was developed in isolation. Having said that, the proposal is a reasonable approach for this functionality that takes into account the various constrains and security considerations that come with changing the HTML parser.",
"mozPositionDetail": "We're not convinced that the complexity this feature introduces upon the HTML parser carries its weight in terms of usefulness for web developers. There's also a risk that the processing model is not compatible with a future declarative custom elements feature as it was developed in isolation. Having said that, the proposal is a reasonable approach for this functionality that takes into account the various constraints and security considerations that come with changing the HTML parser.",

@annevk annevk merged commit 521fe18 into master Dec 7, 2020
@annevk annevk deleted the annevk/shadow branch December 7, 2020 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinthomson martinthomson martinthomson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Declarative Shadow DOM
2 participants
@annevk @martinthomson