Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider displaying both translated and English articles inside the "Top 3" section of the topic card and calculate the "View All {x} Articles" based on both types in non en-US locales #2176

Closed
emilghittasv opened this issue Feb 5, 2025 · 2 comments
Assignees

Comments

@emilghittasv
Copy link
Collaborator

Description
Currently, the topic cards in non en-US locales are displaying the following:

  • The articles listed inside the "Top 3" section are only articles which were translated for that particular topic.
  • The "View All {X} Articles" counter is calculated taking into account only the translated articles for that particular topic.
  • If the topic does not contain any translations, the topic card is hidden.

Proposed changes:
The topic cards in non en-US locales should take into account both the translated articles and the articles which are inside the "In English" section of that particular topic:

  • The articles listed inside the "Top 3" section should also take into consideration the "In English" articles and list them if they qualify for that position.
  • The "View All {X} Articles" counter should be calculated by taking into account both the translated articles and the articles which are inside the "In English" section for that particular topic.
  • If the topic contains only "In English" articles (no translations), the topic card should still be displayed. The "Top 3" section should contain articles from that category and the "View All {X} Articles" counter is calculated by taking into account those articles.
  • If the topic does not contain any translated or "In English' articles, the topic card must be hidden.
@emilghittasv emilghittasv added the bug Something isn't working label Feb 5, 2025
@github-project-automation github-project-automation bot moved this to ❓ triage in Mozilla Support Feb 5, 2025
@emilghittasv emilghittasv removed the bug Something isn't working label Feb 5, 2025
@emilghittasv emilghittasv moved this from ❓ triage to 🗄 backlog in Mozilla Support Feb 5, 2025
@akatsoulas akatsoulas moved this from 🗄 backlog to 🚀 in progress in Mozilla Support Feb 5, 2025
@akatsoulas akatsoulas self-assigned this Feb 5, 2025
@akatsoulas
Copy link
Collaborator

PR mozilla/kitsune#6490

@akatsoulas akatsoulas moved this from 🚀 in progress to 📚 review in Mozilla Support Feb 5, 2025
@akatsoulas akatsoulas moved this from 📚 review to 🔎 QA in Mozilla Support Feb 5, 2025
@emilghittasv
Copy link
Collaborator Author

I can confirm that this is verified fixed in stage.

  • We are taking into account both the translations and the "fallbacks" (The articles listed inside the "In English" section) when we are calculating the "View All {x} Articles" counter.
  • We are listing only article translations (if there are any) inside the "Top 3" section of the topic card.
  • If there are no article translations we are listing article fallbacks (From the "In English" section) inside the "Top 3" section of the topic card.
  • We are excluding a mix of translated articles & fallbacks inside the "Top 3 section" of the topic card.

I'm moving this ticket inside the release column.

@emilghittasv emilghittasv moved this from 🔎 QA to 🚢 release in Mozilla Support Feb 6, 2025
@github-project-automation github-project-automation bot moved this from 🚢 release to ✔ done in Mozilla Support Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: done
Development

No branches or pull requests

2 participants