Expose fallback documents in topic cards. #6490
Merged
+49
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
akatsoulas
commented
Feb 5, 2025
akatsoulas
commented
- Update counter with fallback docs
escattone
approved these changes
Feb 5, 2025
escattone
reviewed
Feb 5, 2025
| featured_articles = get_featured_articles(product, locale=request.LANGUAGE_CODE, topics=topics) | ||
|
|
||
| # Get both main and fallback documents from the faceted search | ||
| main_docs_data, fallback_docs_data = documents_for( |
There was a problem hiding this comment.
The fact that fallback_docs_data can be None should be accounted for.
* Update counter with fallback docs
akatsoulas
force-pushed
the
topic-cards-fallback-docs
branch
from
e8c1416 to
14dcc4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.