Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TLS Observatory Parser Linting: Cert Lint into TLS Observatory #257

Closed
jcjones opened this issue Sep 7, 2017 · 2 comments
Closed

Comments

@jcjones
Copy link

jcjones commented Sep 7, 2017

Similar but different to #187, this is to integrate the AWS Labs Cert Lint tool's output into the certificate parser's output.

The integration is expected to be via a shell execution of the other utility. If we need to do something more exotic (RPC to a Docker instance, for example), that should be a follow-up. For now, this issue should assume we can call out to the executable and read the results from stdout.

@adamdecaf
Copy link
Contributor

I'd be open to trying this. Would tls-observatory need to worry about cloning and installing certlint?

Would this be in a new worker? (Either one worker per cert lint tool or all tools under one worker.)

@jvehent
Copy link
Contributor

jvehent commented Mar 22, 2018

I think this would be a new worker, probably similar to evChecker that also executes a separate binary. The docker image will need to retrieve and build certlint as part of the travisci run.

adamdecaf added a commit to adamdecaf/tls-observatory that referenced this issue Mar 25, 2018
adamdecaf added a commit to adamdecaf/tls-observatory that referenced this issue Mar 25, 2018
adamdecaf added a commit to adamdecaf/tls-observatory that referenced this issue Mar 25, 2018
adamdecaf added a commit to adamdecaf/tls-observatory that referenced this issue Mar 25, 2018
adamdecaf added a commit to adamdecaf/tls-observatory that referenced this issue Mar 25, 2018
adamdecaf added a commit to adamdecaf/tls-observatory that referenced this issue Apr 9, 2018
adamdecaf added a commit to adamdecaf/tls-observatory that referenced this issue Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants