Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update django to 3.2.13 in dev.in too #7445

Merged
merged 6 commits into from
May 13, 2022
Merged

Conversation

La0
Copy link
Collaborator

@La0 La0 commented May 13, 2022

The dev.in was still referencing the old version of Django, this changes affects unit tests on CI and local development (but not in stage nor production).

Packages updated:

  • pytest-django to get official support for django 3.2
  • pytest-freezegun is not compatible with django 3.2, we have to use a fork (as long as this issue is not fixed)
  • dockerflow to get support for django 3.2 (and even 4.0)

After these dependencies were updated, the tests only failed on the issue already detected in Bug 1768270 about aggregate in cycle_data. The id=Max("id") was useless and introduces an incompatibility in Django 3.2 as the following Count must use a field, and not an aggregate (which made no sense).

@La0 La0 marked this pull request as draft May 13, 2022 12:16
@La0 La0 marked this pull request as ready for review May 13, 2022 13:07
@La0 La0 requested review from jmaher and Archaeopteryx May 13, 2022 13:07
@jmaher jmaher merged commit 81d502c into mozilla:master May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants