chore: migrate reactstrap to react bootstrap

[camd]

This made a lot of changes. Thankfully, there is a very similar, modern package called react-bootstrap that I was able to upgrade to. This looks to be working quite well. But I am not able to log into Push Health to check that yet.

[jmaher]

this has a failing test that seems to be something new.

here are docs to run the tests locally:
https://treeherder.readthedocs.io/testing.html

[codecov-commenter]

Codecov Report

❌ Patch coverage is 61.96319% with 62 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.66%. Comparing base (3c22ba9) to head (5fe367f).
⚠️ Report is 7 commits behind head on master.

Files with missing lines	Patch %	Lines
ui/push-health/ClassificationGroup.jsx	41.17%	10 Missing ⚠️
ui/infra-compare/InfraCompareTableRow.jsx	0.00%	8 Missing ⚠️
ui/push-health/Test.jsx	20.00%	8 Missing ⚠️
ui/perfherder/alerts/StatusDropdown.jsx	40.00%	6 Missing ⚠️
ui/perfherder/shared/Pagination.jsx	42.85%	4 Missing ⚠️
ui/perfherder/compare/SelectorCard.jsx	62.50%	3 Missing ⚠️
ui/shared/RevisionInformation.jsx	0.00%	3 Missing ⚠️
ui/job-view/details/summary/ActionBar.jsx	33.33%	2 Missing ⚠️
ui/job-view/details/summary/LogItem.jsx	0.00%	2 Missing ⚠️
ui/shared/DropdownMenuItems.jsx	66.66%	2 Missing ⚠️
... and 13 more

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #8897      +/-   ##
==========================================
- Coverage   77.67%   77.66%   -0.02%     
==========================================
  Files         577      577              
  Lines       29044    29066      +22     
  Branches     3573     3607      +34     
==========================================
+ Hits        22561    22574      +13     
- Misses       6318     6327       +9     
  Partials      165      165              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Archaeopteryx]

1. All these !important rules feel like a hack - can they be avoided?
2. Is there a caller for this class? Neither in pre-existing nor in new code I can find one.

[camd]

Yes, let's remove this class.

[Archaeopteryx]

This had to be reverted:

• Repository dropdowns were shown as list because they did not contain <Dropdown.Menu>. After it had been added to DropdownMenuItems.jsx, the dropdowns worked but
  • dropdown_menu_test.jsx failed. After a toggle got added and click on it simulated, the menu items were still not found.
  • The dropdowns of some menus in perfherder were detached from their toggles.
• The bugfiler modal is broken:
  • Checkboxes and their labels float in the dialog
  • The checkboxes and labels are too large.
  • The empty 'Regressed By' textbox does not accept input. Unknown if this an issue with an element overlaying it or a functional regression.

@camd

[camd]

@Archaeopteryx : do you have any more specifics about the Repository dropdowns? The main one looks good to me. But is there a drop-down that somewhere else that's not working right?

Also, do you have any specific drop downs in perforator where the menus were detached from their toggles? I can't seem to find them.