Skip to content

Commit

Permalink
Correct the process description: releasing backend crates will not au…
Browse files Browse the repository at this point in the history
…tomatically create a tag
  • Loading branch information
badboy committed Jun 21, 2023
1 parent 83bf7ea commit 2978216
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion docs/release-process.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ Steps:
worthwhile anyway!.
* Release the crates: `cargo release-backend-crates -x {MAJOR}.{MINOR}.{PATCH}`.
* **This will publish the new releases on crates.io**
This will create a local git tag, but does not push it to github.
* This will **NOT** create a local git tag.

1. Release `uniffi`
* **Do not execute this before the previous step.** It depends on the published crates from that step
Expand Down
2 changes: 1 addition & 1 deletion release.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
tag-name = "v{{version}}"
consolidate-commits = true

shared-version=false
shared-version = false

# Disabling auto pushing for now to avoid accidents (although we can still "accidentally" publish
# to crates.io, so it's not clear this is saving us anything?)
Expand Down

0 comments on commit 2978216

Please sign in to comment.