Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python bindings: use bytes for sequence<u8> #1299

Closed
tomtau opened this issue Jul 19, 2022 · 0 comments · Fixed by #1543
Closed

Python bindings: use bytes for sequence<u8> #1299

tomtau opened this issue Jul 19, 2022 · 0 comments · Fixed by #1543

Comments

@tomtau
Copy link

tomtau commented Jul 19, 2022 •
edited by data-sync-user
Loading

currently, sequence<u8> is mapped to a list of integers, while it may make more sense to use bytes or byterarray

┆Issue is synchronized with this Jira Task
┆friendlyId: UNIFFI-181
This was referenced May 15, 2023
Closed
Merged
heinrich5991 added a commit to heinrich5991/uniffi-rs that referenced this issue May 19, 2023
@heinrich5991
Introduce bytes type
1aee74b 
This type is mapped to the native bytestring type in the various
languages, i.e.

- Kotlin: `UByteArray`
- Python: `bytes`
- Ruby: `String` with `Encoding::BINARY`
- Swift: `Data`

Also add tests exercising this new type.

Fixes mozilla#1299.
Fixes mozilla#1541.
heinrich5991 added a commit to heinrich5991/uniffi-rs that referenced this issue May 22, 2023
@heinrich5991
Introduce bytes type
85c71af 
This type is mapped to the native bytestring type in the various
languages, i.e.

- Kotlin: `UByteArray`
- Python: `bytes`
- Ruby: `String` with `Encoding::BINARY`
- Swift: `Data`

Also add tests exercising this new type.

Fixes mozilla#1299.
Fixes mozilla#1541.
heinrich5991 added a commit to heinrich5991/uniffi-rs that referenced this issue May 22, 2023
@heinrich5991
Introduce bytes type
2f5cbd2 
This type is mapped to the native bytestring type in the various
languages, i.e.

- Kotlin: `UByteArray`
- Python: `bytes`
- Ruby: `String` with `Encoding::BINARY`
- Swift: `Data`

Also add tests exercising this new type.

Fixes mozilla#1299.
Fixes mozilla#1541.
heinrich5991 added a commit to heinrich5991/uniffi-rs that referenced this issue May 23, 2023
@heinrich5991
Introduce bytes type
e5c8f75 
This type is mapped to the native bytestring type in the various
languages, i.e.

- Kotlin: `UByteArray`
- Python: `bytes`
- Ruby: `String` with `Encoding::BINARY`
- Swift: `Data`

Also add tests exercising this new type.

Fixes mozilla#1299.
Fixes mozilla#1541.
mhammond pushed a commit that referenced this issue May 23, 2023
@heinrich5991
Introduce bytes type (#1543)
f243005 
This type is mapped to the native bytestring type in the various
languages, i.e.

- Kotlin: `ByteArray`
- Python: `bytes`
- Ruby: `String` with `Encoding::BINARY`
- Swift: `Data`

Also add tests exercising this new type.

Fixes #1299.
Fixes #1541.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce bytes type heinrich5991/uniffi-rs
1 participant
@tomtau