-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
External types don't work if they're not used in an interface #1872
Comments
One use-case here is nested types. Suppose you wanted export a function that used the Another use case is simply re-exporting a type. Suppose the |
…markh,janerik,supply-chain-reviewers,mach-reviewers,ahal Updated uniffi-bindgen-gecko-js to work with UniFFI 0.25.2: - Use `config.toml` to list UniFFI sources. This makes it easier to associate data with them, for example the `crate_name` field that's now required to generate the sources. - Enable the `extern-rustbuffer` feature on `uniffi_core` - Updated the external types fixture to work around mozilla/uniffi-rs#1872 Ran mach vendor and mach cargo vet to update the Rust crates. Differential Revision: https://phabricator.services.mozilla.com/D195163
…markh,janerik,supply-chain-reviewers,mach-reviewers,ahal Updated uniffi-bindgen-gecko-js to work with UniFFI 0.25.2: - Use `config.toml` to list UniFFI sources. This makes it easier to associate data with them, for example the `crate_name` field that's now required to generate the sources. - Enable the `extern-rustbuffer` feature on `uniffi_core` - Updated the external types fixture to work around mozilla/uniffi-rs#1872 Ran mach vendor and mach cargo vet to update the Rust crates. Differential Revision: https://phabricator.services.mozilla.com/D195163 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/375a5bb63fa774ba65f3426c93cac31e774c29f4
…markh,janerik,supply-chain-reviewers,mach-reviewers,ahal Updated uniffi-bindgen-gecko-js to work with UniFFI 0.25.2: - Use `config.toml` to list UniFFI sources. This makes it easier to associate data with them, for example the `crate_name` field that's now required to generate the sources. - Enable the `extern-rustbuffer` feature on `uniffi_core` - Updated the external types fixture to work around mozilla/uniffi-rs#1872 Ran mach vendor and mach cargo vet to update the Rust crates. Differential Revision: https://phabricator.services.mozilla.com/D195163
…markh,janerik,supply-chain-reviewers,mach-reviewers,ahal Updated uniffi-bindgen-gecko-js to work with UniFFI 0.25.2: - Use `config.toml` to list UniFFI sources. This makes it easier to associate data with them, for example the `crate_name` field that's now required to generate the sources. - Enable the `extern-rustbuffer` feature on `uniffi_core` - Updated the external types fixture to work around mozilla/uniffi-rs#1872 Ran mach vendor and mach cargo vet to update the Rust crates. Differential Revision: https://phabricator.services.mozilla.com/D195163
…markh,janerik,supply-chain-reviewers,mach-reviewers,ahal Updated uniffi-bindgen-gecko-js to work with UniFFI 0.25.2: - Use `config.toml` to list UniFFI sources. This makes it easier to associate data with them, for example the `crate_name` field that's now required to generate the sources. - Enable the `extern-rustbuffer` feature on `uniffi_core` - Updated the external types fixture to work around mozilla/uniffi-rs#1872 Ran mach vendor and mach cargo vet to update the Rust crates. Differential Revision: https://phabricator.services.mozilla.com/D195163 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/cf885f915fdf19e6901851c4250c030b6b4c7d52
…markh,janerik,supply-chain-reviewers,mach-reviewers,ahal Updated uniffi-bindgen-gecko-js to work with UniFFI 0.25.2: - Use `config.toml` to list UniFFI sources. This makes it easier to associate data with them, for example the `crate_name` field that's now required to generate the sources. - Enable the `extern-rustbuffer` feature on `uniffi_core` - Updated the external types fixture to work around mozilla/uniffi-rs#1872 Ran mach vendor and mach cargo vet to update the Rust crates. Differential Revision: https://phabricator.services.mozilla.com/D195163
…markh,janerik,supply-chain-reviewers,mach-reviewers,ahal Updated uniffi-bindgen-gecko-js to work with UniFFI 0.25.2: - Use `config.toml` to list UniFFI sources. This makes it easier to associate data with them, for example the `crate_name` field that's now required to generate the sources. - Enable the `extern-rustbuffer` feature on `uniffi_core` - Updated the external types fixture to work around mozilla/uniffi-rs#1872 Ran mach vendor and mach cargo vet to update the Rust crates. Differential Revision: https://phabricator.services.mozilla.com/D195163 UltraBlame original commit: 375a5bb63fa774ba65f3426c93cac31e774c29f4
…markh,janerik,supply-chain-reviewers,mach-reviewers,ahal Updated uniffi-bindgen-gecko-js to work with UniFFI 0.25.2: - Use `config.toml` to list UniFFI sources. This makes it easier to associate data with them, for example the `crate_name` field that's now required to generate the sources. - Enable the `extern-rustbuffer` feature on `uniffi_core` - Updated the external types fixture to work around mozilla/uniffi-rs#1872 Ran mach vendor and mach cargo vet to update the Rust crates. Differential Revision: https://phabricator.services.mozilla.com/D195163 UltraBlame original commit: cf885f915fdf19e6901851c4250c030b6b4c7d52
…markh,janerik,supply-chain-reviewers,mach-reviewers,ahal Updated uniffi-bindgen-gecko-js to work with UniFFI 0.25.2: - Use `config.toml` to list UniFFI sources. This makes it easier to associate data with them, for example the `crate_name` field that's now required to generate the sources. - Enable the `extern-rustbuffer` feature on `uniffi_core` - Updated the external types fixture to work around mozilla/uniffi-rs#1872 Ran mach vendor and mach cargo vet to update the Rust crates. Differential Revision: https://phabricator.services.mozilla.com/D195163 UltraBlame original commit: 375a5bb63fa774ba65f3426c93cac31e774c29f4
…markh,janerik,supply-chain-reviewers,mach-reviewers,ahal Updated uniffi-bindgen-gecko-js to work with UniFFI 0.25.2: - Use `config.toml` to list UniFFI sources. This makes it easier to associate data with them, for example the `crate_name` field that's now required to generate the sources. - Enable the `extern-rustbuffer` feature on `uniffi_core` - Updated the external types fixture to work around mozilla/uniffi-rs#1872 Ran mach vendor and mach cargo vet to update the Rust crates. Differential Revision: https://phabricator.services.mozilla.com/D195163 UltraBlame original commit: cf885f915fdf19e6901851c4250c030b6b4c7d52
…markh,janerik,supply-chain-reviewers,mach-reviewers,ahal Updated uniffi-bindgen-gecko-js to work with UniFFI 0.25.2: - Use `config.toml` to list UniFFI sources. This makes it easier to associate data with them, for example the `crate_name` field that's now required to generate the sources. - Enable the `extern-rustbuffer` feature on `uniffi_core` - Updated the external types fixture to work around mozilla/uniffi-rs#1872 Ran mach vendor and mach cargo vet to update the Rust crates. Differential Revision: https://phabricator.services.mozilla.com/D195163 UltraBlame original commit: 375a5bb63fa774ba65f3426c93cac31e774c29f4
…markh,janerik,supply-chain-reviewers,mach-reviewers,ahal Updated uniffi-bindgen-gecko-js to work with UniFFI 0.25.2: - Use `config.toml` to list UniFFI sources. This makes it easier to associate data with them, for example the `crate_name` field that's now required to generate the sources. - Enable the `extern-rustbuffer` feature on `uniffi_core` - Updated the external types fixture to work around mozilla/uniffi-rs#1872 Ran mach vendor and mach cargo vet to update the Rust crates. Differential Revision: https://phabricator.services.mozilla.com/D195163 UltraBlame original commit: cf885f915fdf19e6901851c4250c030b6b4c7d52
…markh,janerik,supply-chain-reviewers,mach-reviewers,ahal Updated uniffi-bindgen-gecko-js to work with UniFFI 0.25.2: - Use `config.toml` to list UniFFI sources. This makes it easier to associate data with them, for example the `crate_name` field that's now required to generate the sources. - Enable the `extern-rustbuffer` feature on `uniffi_core` - Updated the external types fixture to work around mozilla/uniffi-rs#1872 Ran mach vendor and mach cargo vet to update the Rust crates. Differential Revision: https://phabricator.services.mozilla.com/D195163 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/d4a294b46ab8b75d97f87e6b75c909f3e597a531
…markh,janerik,supply-chain-reviewers,mach-reviewers,ahal Updated uniffi-bindgen-gecko-js to work with UniFFI 0.25.2: - Use `config.toml` to list UniFFI sources. This makes it easier to associate data with them, for example the `crate_name` field that's now required to generate the sources. - Enable the `extern-rustbuffer` feature on `uniffi_core` - Updated the external types fixture to work around mozilla/uniffi-rs#1872 Ran mach vendor and mach cargo vet to update the Rust crates. Differential Revision: https://phabricator.services.mozilla.com/D195163
…markh,janerik,supply-chain-reviewers,mach-reviewers,ahal Updated uniffi-bindgen-gecko-js to work with UniFFI 0.25.2: - Use `config.toml` to list UniFFI sources. This makes it easier to associate data with them, for example the `crate_name` field that's now required to generate the sources. - Enable the `extern-rustbuffer` feature on `uniffi_core` - Updated the external types fixture to work around mozilla/uniffi-rs#1872 Ran mach vendor and mach cargo vet to update the Rust crates. Differential Revision: https://phabricator.services.mozilla.com/D195163
…markh,janerik,supply-chain-reviewers,mach-reviewers,ahal Updated uniffi-bindgen-gecko-js to work with UniFFI 0.25.2: - Use `config.toml` to list UniFFI sources. This makes it easier to associate data with them, for example the `crate_name` field that's now required to generate the sources. - Enable the `extern-rustbuffer` feature on `uniffi_core` - Updated the external types fixture to work around mozilla/uniffi-rs#1872 Ran mach vendor and mach cargo vet to update the Rust crates. Differential Revision: https://phabricator.services.mozilla.com/D195163 UltraBlame original commit: d4a294b46ab8b75d97f87e6b75c909f3e597a531
…markh,janerik,supply-chain-reviewers,mach-reviewers,ahal Updated uniffi-bindgen-gecko-js to work with UniFFI 0.25.2: - Use `config.toml` to list UniFFI sources. This makes it easier to associate data with them, for example the `crate_name` field that's now required to generate the sources. - Enable the `extern-rustbuffer` feature on `uniffi_core` - Updated the external types fixture to work around mozilla/uniffi-rs#1872 Ran mach vendor and mach cargo vet to update the Rust crates. Differential Revision: https://phabricator.services.mozilla.com/D195163 UltraBlame original commit: d4a294b46ab8b75d97f87e6b75c909f3e597a531
…markh,janerik,supply-chain-reviewers,mach-reviewers,ahal Updated uniffi-bindgen-gecko-js to work with UniFFI 0.25.2: - Use `config.toml` to list UniFFI sources. This makes it easier to associate data with them, for example the `crate_name` field that's now required to generate the sources. - Enable the `extern-rustbuffer` feature on `uniffi_core` - Updated the external types fixture to work around mozilla/uniffi-rs#1872 Ran mach vendor and mach cargo vet to update the Rust crates. Differential Revision: https://phabricator.services.mozilla.com/D195163 UltraBlame original commit: d4a294b46ab8b75d97f87e6b75c909f3e597a531
If you define an external type, but don't use it in an exporting function/method, then we don't actually import the type in the bindings.
Here's a branch that contains a test for this and tries to fix it, although I couldn't get it all working: https://github.com/bendk/uniffi-rs/tree/ext-type-imports
The text was updated successfully, but these errors were encountered: