-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Callback interface method cannot return callback interface #1947
Comments
bendk
added a commit
to bendk/uniffi-rs
that referenced
this issue
Jan 22, 2024
…a#1947) As mentioned in the `fnsig` code, I feel like this is a bid of a band-aid. However, I think a real fix would require significant changes to the FFI trait system and I don't want to do that so close to the v0.26 release.
bendk
added a commit
to bendk/uniffi-rs
that referenced
this issue
Jan 22, 2024
…a#1947) The easy part was implementing `LiftReturn`. The hard part was figuring out how to handle TYPE_ID_META in the metadata code. In general, we have an issue: should we get that from `Lift`/`LiftReturn` or `Lower`/`LowerReturn`. As mentioned in the `fnsig` code, I feel like this is a bid of a band-aid. However, I think a real fix would require significant changes to the FFI trait system and I don't want to do that so close to the v0.26 release.
bendk
added a commit
to bendk/uniffi-rs
that referenced
this issue
Jan 22, 2024
…a#1947) The easy part was implementing `LiftReturn`. The hard part was figuring out how to handle TYPE_ID_META in the metadata code. In general, we have an issue: should we get that from `Lift`/`LiftReturn` or `Lower`/`LowerReturn`. As mentioned in the `fnsig` code, I feel like this is a bid of a band-aid. However, I think a real fix would require significant changes to the FFI trait system and I don't want to do that so close to the v0.26 release.
bendk
added a commit
that referenced
this issue
Jan 22, 2024
The easy part was implementing `LiftReturn`. The hard part was figuring out how to handle TYPE_ID_META in the metadata code. In general, we have an issue: should we get that from `Lift`/`LiftReturn` or `Lower`/`LowerReturn`. As mentioned in the `fnsig` code, I feel like this is a bid of a band-aid. However, I think a real fix would require significant changes to the FFI trait system and I don't want to do that so close to the v0.26 release.
Fixed in 6f9d65a |
Thank you 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In uniffi 25 a callback interface cannot return another callback interface. This used to work up to uniffi 24.3.
Guessing this was broken in #1766 by @bendk .
test.udl
:lib.rs
:Error:
The text was updated successfully, but these errors were encountered: