Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change MOZ_RELEASE_ASSERT to MOZ_ASSERT #326

Closed
piatra opened this issue Oct 14, 2020 · 0 comments
Closed

Change MOZ_RELEASE_ASSERT to MOZ_ASSERT #326

piatra opened this issue Oct 14, 2020 · 0 comments
Assignees
@piatra

Comments

@piatra
Copy link
Contributor

piatra commented Oct 14, 2020 •
edited by data-sync-user
Loading

From my understanding of DebugOnly.h we shouldn't assert using MOZ_RELEASE_ASSERT. This is preventing the nimbus-sdk vendoring to build in release.
I'll be taking this issue (I can't assign myself).

uniffi-rs/uniffi_bindgen/src/bindings/gecko_js/templates/macros.cpp

Line 52 in 6ec1d44

MOZ_RELEASE_ASSERT(ok_);

┆Issue is synchronized with this Jira Task
@dmose dmose assigned dmose and piatra and unassigned dmose Oct 14, 2020
@rfk rfk closed this as completed in 5ac21b9 Oct 14, 2020
rfk added a commit that referenced this issue Oct 14, 2020
@rfk
Merge pull request #327 from piatra/issue-326
ea7703f 
Change MOZ_RELEASE_ASSERT to MOZ_ASSERT. Fixes #326
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@piatra piatra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dmose @piatra