Make use of implicit format string arguments #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplatte
force-pushed
the
jplatte/format-args
branch
from
bf54b66 to
60d830b
Compare
|
I like the string formatting changes (ie, 60d830b plus the minver bump) - but did you mean to include some of the macro work here too? |
|
(and to be clear, I don't not like the macro changes, but they require more than a rubber stamp :) |
|
This is a draft PR because it contains all of the commits from #1259 from the time of creating it. I intend to rebase once that is merged so there will be no more macro changes. |
jplatte
force-pushed
the
jplatte/format-args
branch
from
60d830b to
317a944
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #1259