Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proc-macro: Some improvements to unresolved types #1379

Merged
merged 3 commits into from
Oct 25, 2022
Merged

proc-macro: Some improvements to unresolved types #1379

merged 3 commits into from
Oct 25, 2022

Conversation

jplatte
Copy link
Collaborator

@jplatte jplatte commented Oct 21, 2022

Related to #1257.

@jplatte jplatte requested a review from a team as a code owner October 21, 2022 09:40
@jplatte jplatte requested review from bendk and removed request for a team October 21, 2022 09:40
bendk
bendk approved these changes Oct 24, 2022
View reviewed changes
Copy link
Contributor

@bendk bendk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's merge.

bendk
bendk requested changes Oct 24, 2022
View reviewed changes
Copy link
Contributor

@bendk bendk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it doesn't look so good now that I see the CI failures. The basic approach seems right, but maybe you meant iter_mut()?

@jplatte
Copy link
Collaborator Author

jplatte commented Oct 24, 2022

Oh, weird, I didn't see those before. Where I used values_mut, the type it is called on should be BTreeMap, but clearly something is not quite right. I will look into it tomorrow.

@jplatte
Copy link
Collaborator Author

jplatte commented Oct 25, 2022

Ah, I split local changes into two PRs, the BTreeMap change was in #1377. So this just needs a rebase.

@jplatte jplatte force-pushed the jplatte/unresolved branch from b7c7bce to 1a60153 Compare October 25, 2022 12:54
@jplatte jplatte requested a review from bendk October 25, 2022 14:08
bendk
bendk approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@bendk bendk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, let's merge.

@bendk bendk merged commit 89b9dd8 into mozilla:main Oct 25, 2022
@jplatte jplatte deleted the jplatte/unresolved branch October 25, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bendk bendk bendk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jplatte @bendk