proc-macro: Add support for fallible functions #1408
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplatte
force-pushed
the
jplatte/proc-macro-errors
branch
3 times, most recently
from
bdd9532 to
cd1bac4
Compare
jplatte
force-pushed
the
jplatte/proc-macro-errors
branch
3 times, most recently
from
31b8d51 to
f272c9d
Compare
jplatte
requested review from
mhammond and
bendk
and removed request for
a team
jplatte
commented
Dec 13, 2022
|
I was able to rerun from the CircleCI website but it doesn't seem to change anything 🤷🏼 |
badboy
approved these changes
Dec 13, 2022
Comment on lines
+64
to
+65
| #[automatically_derived] | ||
| impl ::uniffi::FfiError for #ident {} |
There was a problem hiding this comment.
I have been trying to understand why we have this trait.
Is this just a marker?
It doesn't seem to be used anywhere or am I missing something?
There was a problem hiding this comment.
Yeah, just a marker AFAICT.
jplatte
force-pushed
the
jplatte/proc-macro-errors
branch
from
172c8af to
b4f784d
Compare
|
GitHub is being a bit weird, this is going to be merged as #1423. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1257.
Remaining tasks:
Errorderive macro