Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlin: Add an upper-bound for UniFfiHandleMap #1550

Merged
merged 1 commit into from
May 22, 2023

Conversation

bendk
Copy link
Contributor

@bendk bendk commented May 19, 2023

Without this a user could pass a null value, which isn't correct. This prevents compiler errors when I try to use the new UniFFI version with application-services.

Without this a user could pass a null value, which isn't correct. This
prevents compiler errors when I try to use the new UniFFI version with
application-services.
@bendk bendk requested a review from a team as a code owner May 19, 2023 00:02
@bendk bendk requested review from skhamis and removed request for a team May 19, 2023 00:02
Copy link
Contributor

@skhamis skhamis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bendk bendk merged commit cb52566 into mozilla:main May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants