Be more picky about int/float arguments in Ruby #1596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badboy
approved these changes
Jun 15, 2023
badboy
reviewed
Jun 15, 2023
heinrich5991
force-pushed
the
pr_less_coercing_rb
branch
from
f64a167
to
ce23a21
Compare
There are implicit integer conversions using `to_int` and no conversions for floats. This is correct according to https://idiosyncratic-ruby.com/54-try-converting.html and Ruby's Discord https://discord.com/channels/518658712081268738/788748516352458752/1118618993276760105.
heinrich5991
force-pushed
the
pr_less_coercing_rb
branch
from
ce23a21
to
2de60da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are implicit integer conversions using
to_intand no conversions for floats. This is correct according tohttps://idiosyncratic-ruby.com/54-try-converting.html and Ruby's Discord https://discord.com/channels/518658712081268738/788748516352458752/1118618993276760105.