Remove the Kotlin FFIObject base class. #1942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhammond
requested review from
badboy and
bendk
and removed request for
a team
mhammond
force-pushed
the
kill-ffi-object
branch
2 times, most recently
from
cf7e51c to
34a3789
Compare
bendk
approved these changes
Jan 17, 2024
| // struct after it has been dropped, and because we must expose a public API for freeing | ||
| // the Kotlin wrapper object in lieu of reliable finalizers. The core requirements are: | ||
| // | ||
| // * Each `FFIObject` instance holds an opaque pointer to the underlying Rust struct. |
There was a problem hiding this comment.
Nit: FFIObject no longer exists. Maybe this could just say "instance".
mhammond
force-pushed
the
kill-ffi-object
branch
2 times, most recently
from
78677e4 to
f53533a
Compare
Each interface now includes the functionality directly in the implementation. This is towards supporting interfaces as errors; such interfaces will need to derive from `Exception` and Kotlin/Java don't allow multiple base-classes.
mhammond
force-pushed
the
kill-ffi-object
branch
from
f53533a to
67e34d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each interface now includes the functionality directly in the implementation.
This is towards supporting interfaces as errors; such interfaces will need to derive from
Exceptionand Kotlin/Java don't allow multiple base-classes.