Adding the TypeId FFI trait
#1952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The metadata code now uses this trait to get the `TYPE_ID_METADATA` rather than Lift/Lower. This feels cleaner, since it was often not clear which trait to use before. This removes the hacky handling of type id metadata for callback interfaces that I added in mozilla#1950
bendk
force-pushed
the
metadata-ffi-trait
branch
from
6725e5e to
06df57c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metadata code now uses this trait to get the
TYPE_ID_METADATArather than Lift/Lower. This feels cleaner, since it was often not clear which trait to use before. This removes the hacky handling of type id metadata for callback interfaces that I added in #1950.Let's not merge this until after 0.26.0 is released. It feels like too big of a change at this point in the process.