Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate/Simplify the foreign bindings handlemap code #1969

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Consolidate/Simplify the foreign bindings handlemap code #1969

merged 1 commit into from
Jan 30, 2024

Commits on Jan 30, 2024

  1. Consolidate/Simplify the foreign bindings handlemap code 

    I'm trying to get mozilla#1823 merged now that 0.26.0 is out, but I'll break it
up a bit to make it easier.  The first step is consolidating the foreign
handle map code.

Foreign now languages define 1 handle map and use it for all object
types. I tried to simplify the handle map implementations, the had a lot
of features that we weren't using at all and seemed to be only
half-implemented to me, like the right map and counter map.

Handles are always `u64` values.  This allows us to remove some code
like the `USize` handling on Kotlin and the
`FfiType::RustFutureContinuationData` variant.
    @bendk
    bendk committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    93f7981 View commit details
    Browse the repository at this point in the history