Adding support for Rust async trait methods #1981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhammond
approved these changes
Feb 7, 2024
| }; | ||
| ``` | ||
|
|
||
| When using proc-macros, make sure to put `#[uniffi::export]` outside the `#[async_trait]` attribute: |
There was a problem hiding this comment.
Is it strictly necessary for it to be "outside the #[async_trait] attribute"? I thought it would work if those 2 lines were swapped?
There was a problem hiding this comment.
I'm not sure exactly why, but it fails because of the lifetimes async_trait adds:
| - lifetime `'async_trait` is missing in item created through this procedural macro
332 | pub trait SayAfterTrait: Send + Sync {
333 | async fn say_after(&self, ms: u16, who: String) -> String;
| ^^^^^ undeclared lifetime
This was pretty easy, it mostly meant not hard coding that we don't support async methods and which order to apply `#[uniffi::export]` vs `#[async_trait::async_trait]`. The next step is foreign-implemented traits.
bendk
force-pushed
the
async-rust-trait-interfaces
branch
from
7aa00f2
to
81893ca
Compare
|
Do you have an estimate of when the next release will be? My team is strongly dependent on this change |
|
No estimate, but you can try to use the git commit in to get the feature. Other teams have had success with that. |
|
Thanks, that did work |
mgeisler
added a commit
to mgeisler/mls-rs
that referenced
this pull request
Mar 22, 2024
UniFFI added support for async traits in mozilla/uniffi-rs#1981, but this is not yet released. This commit temporarily introduces a Git dependency on UniFFI to let us test the async functionality which was removed in awslabs#86. An unrelated UniFFI change (mozilla/uniffi-rs#1840) made our existing test fail.
mgeisler
added a commit
to mgeisler/mls-rs
that referenced
this pull request
Mar 22, 2024
UniFFI added support for async traits in mozilla/uniffi-rs#1981, but this is not yet released. This commit temporarily introduces a Git dependency on UniFFI to let us test the async functionality which was removed in awslabs#86. An unrelated UniFFI change (mozilla/uniffi-rs#1840) made our existing test fail.
mgeisler
added a commit
to mgeisler/mls-rs
that referenced
this pull request
Mar 23, 2024
UniFFI added support for async traits in mozilla/uniffi-rs#1981, but this is not yet released. This commit temporarily introduces a Git dependency on UniFFI to let us test the async functionality which was removed in awslabs#86. An unrelated UniFFI change (mozilla/uniffi-rs#1840) made our existing test fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was pretty easy, it mostly meant not hard coding that we don't support async methods and which order to apply
#[uniffi::export]vs#[async_trait::async_trait].The next step is foreign-implemented traits.