Make uniffi_build optional in uniffi_macros
#2019
Conversation
mgeisler
force-pushed
the
remove-uniffi-build-dep
branch
from
03acd43 to
5b9956b
Compare
|
This seems fine to me once the conflicts and CI failures are dealt with. |
mgeisler
force-pushed
the
remove-uniffi-build-dep
branch
from
5b9956b to
a7ace94
Compare
Thanks a lot! I've actually been struggling to get Here, the problem seems to be a Serde dependency which doens't enable the |
mgeisler
force-pushed
the
remove-uniffi-build-dep
branch
from
a7ace94 to
7ba0ad3
Compare
The code built without this, but that seems to because of an accident
since the derive feature is not a default serde feature.
I noticed this when trying to make uniffi_build an optional
dependency of uniffi_macros — for some reason I don’t understand, this
would make `cargo build -p uniffi_macros` fail wtih:
error: cannot find derive macro `Deserialize` in this scope
--> uniffi_macros/src/util.rs:29:14
|
29 | #[derive(Deserialize)]
| ^^^^^^^^^^^
|
The error makes sense since the derive feature wasn’t enabled. What
does not make sense to me is that the error wasn’t triggered before.
As far as I can see, the dependency on uniffi_build is not needed for the macros used by regular clients of UniFFI — it is only used to create a convenience macro for the UI tests. I named the new feature “trybuild” after the description of the macro. Please let me know if you have preferences for a better name. The overall goal here is to minimize the number of crates I need to vendor to use UniFFI — I’m hoping to get away with checking in the generated target language sources, so I’m currently focusing on the dependencies in the rest of the code base.
mgeisler
force-pushed
the
remove-uniffi-build-dep
branch
from
7ba0ad3 to
0a5a868
Compare
|
Thanks for the quick review!
To follow up on this, I asked in the chat room and got a reply super fast — basically, I have a too old Kotlin compiler installed (version 1.3 from Debian testing). The current version is 1.9 and Kotlin 1.3 lacks (at least!) support for trailing commas in several places. So I now simply ignore the Kotlin tests with and this works! |
As far as I can see, the dependency on uniffi_build is not needed for the macros used by regular clients of UniFFI — it is only used to create a convenience macro for the UI tests.
I named the new feature “trybuild” after the description of the macro. Please let me know if you have preferences for a better name.
The overall goal here is to minimize the number of crates I need to vendor to use UniFFI — I’m hoping to get away with checking in the generated target language sources, so I’m currently focusing on the dependencies in the rest of the code base.