WIP - Solves #2000 to conditionally enable uniffi::constructor macro #2086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The proc-macro method is now mentioned upfront, instead of as a bottom note. This provides clearer context for new users.
This PR solves mozilla#2000 - Unable to conditionally enable uniffi::constructor macro.
4 tasks
|
I see; thanks for pointing it out. I went at it with a wrong assumption. I'll get the tests working, they would have caught it earlier. |
|
Have you checked out my comment in the issue? What do you think about the suggested approach? It's probably a bit more involved, but I can try to refactor some things so that it's not too bad. |
|
Closing in favor of #2113 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main discussion happened at #2000
This doesn't break any current test case. WIP because it should include new test cases covering some of the examples mentioned in the original discussion, but I'm still figuring out where they should go. I'll do that later this week.
Reviews are welcome.