-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mention procmacros in the intro docs and other minor doc tweaks #2171
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,13 @@ | ||
This directory contains the tests for external types -- types defined in one crate and used in a | ||
different one. | ||
This directory contains the tests for external types - cross-crate depedencies and libraries | ||
to tie them together. | ||
|
||
- `guid` and `uniffi-one` are dependent crates that define types exported by UniFFI | ||
- `lib` is a library crate that depends on `guid` and `uniffi-one` | ||
- `proc-macro-lib` is another library crate, but this one uses proc-macros rather than UDL files | ||
- `lib` is a library crate that depends on various other crates. | ||
- `proc-macro-lib` is another library crate, but this one uses proc-macros rather than UDL files. | ||
|
||
The various other crates all inter-relate and are ultimately consumed by the above libs: | ||
- `custom-types` is all about wrapping types (eg, Guid, Handle) in a native type (eg, String, u64) | ||
- `uniffi-one` is just a normal other crate also using uniffi. | ||
- `sub-lib` itself consumes and exposes the other types. | ||
- `external-crate` doesn't depend on uniffi but has types we expose. | ||
|
||
etc. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
This is a "sub library" - it is itself a "library" which consumes types from | ||
This is a "sub library" - ie, a crate which consumes types from | ||
other external crates and *also* exports its own composite types and trait | ||
implementations to be consumed by the "main" library. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh TIL we link out to some unrelated CDN. Not sure I like that. Fine for now though, given it's been there for a while.