Fix so cargo_metadata isn't a dependency without the cargo_metadata feature #2200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhammond
force-pushed
the
push-rntxuztvtlkr
branch
from
168ca0b
to
d1af4f1
Compare
…eature. The `uniffi_test` crate unconditionally depends on `cargo_metadata`, and this will be difficult to change. This means that because `uniffi_test` is an unconditional dependency of `uniffi_bindgen`, the `cargo_metadata` feature doesn't actually prevent `uniffi_bindgen` from depending on `cargo_metadata`. The top level `uniffi` create already has a feature `bindgen-tests`. This patch introduces a feature of the same name to `uniffi_bindgen`. Enabling that feature also enables the metadata feature. This means that if you do not enable either of these features you should be able to avoid `cargo_metadata`. This patch also renames the new `cargo_metadata` feature to be `cargo-metadata` to be more consistent with our existing features and Rust feature naming in general.
mhammond
force-pushed
the
push-rntxuztvtlkr
branch
from
d1af4f1
to
e5fc651
Compare
skeet70
approved these changes
Jul 29, 2024
badboy
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
uniffi_testcrate unconditionally depends oncargo_metadata, and this will be difficult to change. This means that becauseuniffi_testis an unconditional dependency ofuniffi_bindgen, thecargo_metadatafeature doesn't actually preventuniffi_bindgenfrom depending oncargo_metadata.The top level
unifficreate already has a featurebindgen-tests. This patch introduces a feature of the same name touniffi_bindgen. Enabling that feature also enables the metadata feature. This means that if you do not enable either of these features you should be able to avoidcargo_metadata.This patch also renames the new
cargo_metadatafeature to becargo-metadatato be more consistent with our existing features and Rust feature naming in general.This is on the path to trying to untangle the requirements for #2195, so I'd love feedback from @skeet70 - note that this doesn't actually fix the issue found there, but it's a step in the right direction. My intention is to push the actual execution of
cargo metadataout to both the cli and touniffi_testing, and this is a step in that direction.