Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a default constructor if none is provided #250

Conversation

jhugman
Copy link
Contributor

@jhugman jhugman commented Aug 18, 2020

Fixes #246.

Implement the Default trait for Constructor, and use it when no constructors are given in the IDL.

Removed the noarg constructors in rondpoint.idl.

@jhugman jhugman requested a review from tarikeshaq August 18, 2020 16:11
Copy link
Contributor

@tarikeshaq tarikeshaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM!

@jhugman jhugman merged commit ac46205 into mozilla:main Aug 18, 2020
@jhugman jhugman deleted the jhugman/246-provide-default-constructor-for-objects branch August 18, 2020 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What to do when no constructor is specified in the IDL?
2 participants