Fixes clippy for consumers #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarikeshaq
commented
Aug 27, 2020
| @@ -89,6 +89,9 @@ | |||
| //! to load and use the compiled rust code via its C-compatible FFI. | |||
| //! | |||
|
|
|||
| #![warn(rust_2018_idioms)] | |||
There was a problem hiding this comment.
The compiler started telling me that the #![warn(rust_2018_idioms)] is ignored if it's not at the crate level, so I moved those here
rfk
approved these changes
Aug 27, 2020
tarikeshaq
force-pushed
the
disable-clippy
branch
from
b474265
to
d29817c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #254
Adds
#[allow(clippy::all)]in all generated functions.A WAY nicer way to do this is to add
#![allow(clippy::all)]but unfortunately that doesn't work because of rust-lang/rfcs#752, although I would be happy if there is a different way to disable clippy on the whole generated file without asking the consumer to do so.Note: I did not add the
#[allow(clippy::all)]for anything other than the functions purely because they didn't complain, I'd be happy to go around doing that if we need to.I also fixed some clippy errors that popped up (not sure if it's because I updated to
1.46)