Add defaults for properties in Records #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhugman
force-pushed
the
188-default-properties
branch
from
8d4678d to
c414ed1
Compare
rfk
reviewed
Oct 7, 2020
| {%- match field.default_value() %} | ||
| {%- when Some with(literal) %} = {{ literal|literal_py }} | ||
| {%- else %} | ||
| {%- endmatch -%} |
There was a problem hiding this comment.
FYI, this will cause problems in python if there are non-default fields following a default field:
>>> def test(one, two=2, three):
... pass
File "<stdin>", line 1
SyntaxError: non-default argument follows default argument>>>
There was a problem hiding this comment.
Yuck. Ok. This was meant to be a quick PR; I think I favour pulling out defaults until we have the bandwidth for #300.
rfk
approved these changes
Oct 7, 2020
jhugman
commented
Oct 7, 2020
| @@ -57,6 +57,7 @@ listOf(-1, 0, 1).map { DictionnaireNombresSignes(it.toByte(), it.toShort(), it.t | |||
| listOf(0, 1).map { DictionnaireNombres(it.toUByte(), it.toUShort(), it.toUInt(), it.toULong()) } | |||
| .affirmAllerRetour(rt::identiqueNombres) | |||
|
|
|||
|
|
|||
jhugman
force-pushed
the
188-default-properties
branch
from
c414ed1 to
725f16c
Compare
Removed the python implementation in favour of #300. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #188.
This small PR adds to #283.