A strawfox for #417 to allow an interface to have a method which take… #418
Conversation
…ch takes an `Arc::clone(self)` Intent is a new attribute is added to such methods (and the method must be on a `[ThreadSafe]` interface). I've chosen `[SomethingSomethingArc]` as the attribute name :) I attempted to change things so handle_map.rs no longer does the ref-deref `&*` magic but instead delegates that to the macros, which only does it if the new attribute exists. This *nearly* works, but has unintended consequences I don't yet understand (ie, the non-threadsafe generated code is using `&*obj` which makes no sense at this hour).
| @@ -83,6 +86,11 @@ impl ThreadsafeCounter { | |||
| self.count.load(Ordering::SeqCst) | |||
| } | |||
| } | |||
|
|
|||
| fn cloneable(self: Arc<Self>) { | |||
There was a problem hiding this comment.
to be clear, I think we want a new example rather than abusing this, but this is OK for demo purposes
There was a problem hiding this comment.
Quick drive by. This looks straightforward enough. I'm sorry I'm not able to suggest any better user-facing names.
(i.e. the non-threadsafe generated code is using &*obj which makes no sense
at this hour).
I left a reason why this happening, but not a solution. :(
| {%- if meth.something_something_arc() -%} | ||
| let _retval = {{ obj.name() }}::{%- call to_rs_call_with_prefix("obj", meth) -%}?; | ||
| {%- else -%} | ||
| let _retval = {{ obj.name() }}::{%- call to_rs_call_with_prefix("&*obj", meth) -%}?; | ||
| {%- endif -%} |
There was a problem hiding this comment.
The method_call_with_result is doing the work of choosing between the two handle_map implementations, so this else block is being seen by both Threadsafe and non-Threadsafe objects.
| pub(super) enum Attribute { | ||
| ByRef, | ||
| Error, | ||
| Threadsafe, | ||
| Throws(String), | ||
| SomethingSomethingArc, |
There was a problem hiding this comment.
I don't really understand the need for this, so I'm not going to much help naming this.
|
I think #419 has longer legs than this, so I don't plan on taking this further. |
…s an
Arc::clone(self)[Had to do a last-minute rebase based on James's recent improvements and hope I didn't do anything even dumber there :]
Intent is a new attribute is added to such methods (and the method must be on
a
[ThreadSafe]interface). I've chosen[SomethingSomethingArc]as theattribute name :)
I attempted to change things so handle_map.rs no longer does the
ref-deref
&*magic but instead delegates that to the macros, whichonly does it if the new attribute exists. This nearly works, but
has unintended consequences I don't yet understand (ie, the
non-threadsafe generated code is using
&*objwhich makes no senseat this hour).