Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codegen backend for Ruby. #464

Merged
merged 1 commit into from
May 26, 2021
Merged

Add codegen backend for Ruby. #464

merged 1 commit into from
May 26, 2021

Conversation

rfk
Copy link
Collaborator

@rfk rfk commented May 26, 2021

This is #436, with some adjustments for landing:

Currently "draft" while I see if I can get cargo test passing cleanly on my local machine, and document and non-obvious steps involved in doing so.

This commit adds support for `uniffi-bindgen -l ruby` to generate
a Ruby module from a UniFFI Rust component.
@rfk
Copy link
Collaborator Author

rfk commented May 26, 2021

Currently "draft" while I see if I can get cargo test passing cleanly on my local machine

Seems like the builtin ruby on Mac is too old, but the ruby installed from homebrew works fine.

@mhammond I'm r+ on this over in #436, but could you please take a glance at the consolidated commit here for final merge?

@rfk rfk marked this pull request as ready for review May 26, 2021 01:29
@rfk rfk requested a review from mhammond May 26, 2021 01:29
@rfk rfk mentioned this pull request May 26, 2021
Copy link
Member

@mhammond mhammond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

github has no :stamp emoji, which would be appropriate for me reviewing a ruby patch. WCGW?

CHANGELOG.md Outdated
- A new **Ruby** codegen backend has been added. You can now call `uniffi-bindgen -l ruby` to
generate a Ruby module that wraps a UniFFI Rust component. Thanks to @saks for contributing
this backend!
- When running `cargo test` locally, you may need to install Ruby and the `ffi` gem
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some time later we should try and improve this a little - It can be tiresome to filter through test failure output each time and go "yep, that just the lack of swift failing" etc - especially when running from different environments, each of which has a different set of test deps installed.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, probably it makes more sense to log a message about skipping the test than the fail it; filed #466 for followup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants