Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove workaround for JNA bug when passing small structs by value. #995

Merged
merged 2 commits into from
Aug 5, 2021

Conversation

badboy
Copy link
Member

@badboy badboy commented Aug 3, 2021

This (partially) reverts commit 937f9b7

The upstream JNA bug1 has been resolved.
JNA 5.7 includes the fix.

We're upgrading our Docker test image to 5.8 already.

Fixes #334

Copy link
Collaborator

@rfk rfk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The "request changes" here is specifically about the versioning in the Swift header file, everything else about this looks great 👍🏻

@badboy badboy requested a review from rfk August 4, 2021 09:44
badboy added 2 commits August 4, 2021 11:44
This (partially) reverts commit 937f9b7

The upstream JNA bug[1] has been resolved.
JNA 5.7 includes the fix.

We're upgrading our Docker test image to 5.8 already.

Fixes mozilla#334

[1]: java-native-access/jna#1259
Copy link
Collaborator

@rfk rfk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@rfk rfk merged commit 0fbce14 into mozilla:main Aug 5, 2021
@badboy badboy deleted the no-more-padding branch August 5, 2021 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert struct-padding workaround once upstream bug is fixed in JNA
2 participants