refactor: changed firefox to firefoxProcess

mozilla · Aug 22, 2016 · 6b6d65d · 6b6d65d
1 parent 1dd0f06
commit 6b6d65d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/src/cmd/run.js b/src/cmd/run.js
@@ -62,7 +62,7 @@ export function defaultWatcherCreator(
 
 export type ReloadStrategyParams = {
   addonId: string,
-  firefoxApp: FirefoxProcess,
+  firefoxProcess: FirefoxProcess,
   client: RemoteFirefox,
   profile: FirefoxProfile,
   sourceDir: string,
@@ -75,15 +75,15 @@ export type ReloadStrategyOptions = {
 
 export function defaultReloadStrategy(
   {
-    addonId, firefoxApp, client, profile, sourceDir, artifactsDir,
+    addonId, firefoxProcess, client, profile, sourceDir, artifactsDir,
   }: ReloadStrategyParams,
   {
     createWatcher=defaultWatcherCreator,
   }: ReloadStrategyOptions = {}
 ): void {
   let watcher: Watchpack;
 
-  firefoxApp.on('close', () => {
+  firefoxProcess.on('close', () => {
     client.disconnect();
     watcher.close();
   });
@@ -261,7 +261,7 @@ export default function run(
         log.debug(
           `Reloading extension when the source changes; id=${addonId}`);
         reloadStrategy({
-          firefoxApp: runningFirefox,
+          firefoxProcess: runningFirefox,
           profile, client, sourceDir, artifactsDir, addonId,
         });
       }

diff --git a/tests/test-cmd/test.run.js b/tests/test-cmd/test.run.js
@@ -308,7 +308,7 @@ describe('run', () => {
         addonId: 'some-addon@test-suite',
         client,
         // $FLOW_IGNORE: fake a Firefox ChildProcess using an EventEmitter for testing reasons.
-        firefoxApp: new EventEmitter(),
+        firefoxProcess: new EventEmitter(),
         profile: {},
         sourceDir: '/path/to/extension/source',
         artifactsDir: '/path/to/web-ext-artifacts/',
@@ -330,9 +330,9 @@ describe('run', () => {
     }
 
     it('cleans up connections when firefox closes', () => {
-      const {firefoxApp, client, watcher, reloadStrategy} = prepare();
+      const {firefoxProcess, client, watcher, reloadStrategy} = prepare();
       reloadStrategy();
-      firefoxApp.emit('close');
+      firefoxProcess.emit('close');
       assert.equal(client.client.disconnect.called, true);
       assert.equal(watcher.close.called, true);
     });