-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't connect to firefox debugger #1509
Comments
Can you show the full log? Was your system under heavy resource constraints? This is my log after running
|
I just tried again using Firefox 66.0b12 and got the same problem, from a clean boot so wasn't running enything else.
|
I'm having the same troubles with Firefox 65.0.1 on Solus.. addon debugger is enabled. My configuration couldn't be simpler, I'm just using the borderify webextension "hello world" tutorial provided by Mozilla, and ran
|
@arcooke Is your issue consistently reproducible? I tried to recreate the problem from the original report (using ArchLinux and the same versions of |
So about that.. I'm sorry. I did the same thing you warned about in your first reply in this thread.. it was throwing these errors, but connecting eventually. I didn't notice it had a 250-retry timeout. I hope you didn't spend any extra time as a result of my report I did manage to get it to error out a few times, but it's probably normal and unrelated to the original post. If I close the web-ext session and relaunch a new one too soon, sometimes it will show an error message and continue through 250 failed retries even if I close the dialog box. However, this only happens if I relaunch a new web-ext session too fast, the previous debugger probably hadn't cleanly disconnected yet or something. So likely unrelated, and you can ignore my posts here. This is not a problem for me. |
@rpl To reduce the odds of reusing a port that may still be in use, what do you think of selecting a known-free port (e.g. like we do at web-ext/src/extension-runners/firefox-android.js Lines 594 to 604 in 358a63a
web-ext are running.
|
@Rob--W 👍 sure, sounds reasonable to me too |
If this is your first contribution, please refer to https://github.com/mozilla/web-ext/blob/master/CONTRIBUTING.md for how to get started. Mentor: @rpl |
Can somebody help me get started with this issue please ^_^ |
@arunikayadav42 Sure, as Rob mentioned in #1509 (comment) we would like to replace the strategy currently used in the In Lines 48 to 55 in 760f3cd
(which starts from a statically defined port number, const REMOTE_PORT = 6005 , and if the connection is refused it tries the next port number).
Then the Line 143 in 760f3cd
and the Line 152 in 760f3cd
These should be the most relevant pieces of code that you will have to carefully read and understand (no worries, we are here to help with that ;-)) and then apply the needed changes. Let me know if you have more questions or you have met some issue while working on the changes. Best, |
Hey! Can I take this up? I know how to get started, read all the comments, just want to know if it's still relevant. |
@rbrishabh sure, feel free to take this. In #1509 (comment) there are some pointers related to the kind of change that we are aiming for. |
* chore: Update web-ext to latest version Fixes mozilla/web-ext#1509 * fix: panning locked images+videos on firefox Pass the event object to the function as it's used there. Fix #1036
Is this a feature request or a bug?
Bug
What is the current behavior?
I wan't to debug my addon using
web-ext run
I get error messages and after a while firefox crashes.
What is the expected or desired behavior?
Being able to connect to the debugger.
Version information (for bug reports)
Source code available here
Output using --verbose output:
The text was updated successfully, but these errors were encountered: