Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict npm version explicitly set in the package.json as supported to prevent renovatebot from updating the lock file to version 2 #2145

Closed
rpl opened this issue Feb 3, 2021 · 0 comments · Fixed by #2144

Comments

@rpl
Copy link
Member

rpl commented Feb 3, 2021

Some recent renovatebot PRs (#2141, #2142, #2143) are failing on CI while running the npm ci step.

The reason for the failure (as described in #2142 (comment)) seems to be triggered because the lockfileVersion: 2 that renovatebot did include in those PR is currently incompatible with npm v6.

As a short term solution we agreed to try to require in the package.json an npm version strictly < than npm v7, which should hopefully be enough to force renovatebot to don't upgrade the lockfileVersion yet.

We should then remove that restriction from the package.json once we are ready to fully migrate to npm v7 (or if in the meantime the incompatibility of the lockfileVersion: 2 with npm v6 is gone).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant