Run extension with a custom Firefox binary #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumar303
force-pushed
the
custom-firefox
branch
6 times, most recently
from
51db667 to
07ac6da
Compare
|
@rpl could you review? |
| * Each class instance variable is a camel case expanded program | ||
| * option. Each option is defined in program.yargs.option(...). | ||
| */ | ||
| export class ProgramOptions { |
There was a problem hiding this comment.
I removed this because it wasn't working (too many errors I could not resolve). I filed #106 to look for a solution.
kumar303
force-pushed
the
custom-firefox
branch
2 times, most recently
from
533531d to
be61c02
Compare
| /* @flow */ | ||
| import build from './build'; | ||
| import run from './run'; | ||
| export {build, run}; |
There was a problem hiding this comment.
This is probably a good candidate for an `export default {build, run}'.
if we do this kind of change, we need to change the corresponding imports [1] to something like:
import defaultCommands from './cmd';
[1]: in https://github.com/mozilla/web-ext/pull/105/files#diff-9589e3a0cc72e26a4814bc9ef05aa2d4R6
and
in https://github.com/mozilla/web-ext/pull/105/files#diff-2d9bd4ae7220a18dfa5b6b6707f45213R7
There was a problem hiding this comment.
ah, good idea. I didn't know that was possible :)
|
@kumar303 looks great +1 |
kumar303
added a commit
that referenced
this pull request
Mar 4, 2016
Run extension with a custom Firefox binary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #71
Some other things:
cli.jsintoprogram.jsbecause all this logic is relatedtemp-dir.jsmain()program code--build-dirspecific tobuildrather than a global option