fix(test): Avoid EPIPE error in "web-ext sign" test #1346
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our fake AMO server, we are immediately sending a response without consuming the HTTP request body. This code pattern is known to cause EPIPE failures (see nodejs/node#12339). The fix is to consume the request body before responding.
Minimal local reproduction (tested with Node.js v10.6.0):
After this patch, the above error does not occur any more. I have also verified that
GET
requests also complete successfully.