Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency eslint to v6 #1635

Merged
merged 1 commit into from
Jul 19, 2019
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jun 22, 2019

This PR contains the following updates:

Package Type Update Change
eslint (source) devDependencies major 5.16.0 -> 6.0.1

Release Notes

eslint/eslint

v6.0.1

Compare Source

v6.0.0

Compare Source


Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@rpl
Copy link
Member

rpl commented Jun 25, 2019

This PR currently depends from #1638 and mozilla/addons-linter#2652

@renovate renovate bot force-pushed the renovate/eslint-6.x branch from f3caa6f to 297d7a8 Compare July 4, 2019 13:24
@@ -2068,7 +2070,6 @@
"deepmerge": "3.2.0",
"dispensary": "0.37.0",
"es6-promisify": "6.0.1",
"eslint": "5.16.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rob--W noticed that in the package-lock.json file renovatebot is removing the explicit eslint dependency from our addons-linter dependency section.

@coveralls
Copy link

coveralls commented Jul 4, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 894a1b6 on renovate/eslint-6.x into 35d07cd on master.

@renovate renovate bot force-pushed the renovate/eslint-6.x branch from 297d7a8 to 9aabede Compare July 19, 2019 14:27
@rpl
Copy link
Member

rpl commented Jul 19, 2019

well, rebuilding the package-lock.json file from scratch (as part of #1663) also had the side effect of fixing the issue on the travis CI job for this renovatebot PR \o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants