Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency flow-bin to v0.110.1 #1738

Merged
merged 1 commit into from
Oct 28, 2019

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 24, 2019

This PR contains the following updates:

Package Type Update Change
flow-bin (changelog) devDependencies patch 0.110.0 -> 0.110.1

Release Notes

flowtype/flow-bin

v0.110.1

Compare Source


Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@coveralls
Copy link

coveralls commented Oct 24, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 048d01d on renovate/flow-bin-0.x into a28f077 on master.

@rpl
Copy link
Member

rpl commented Oct 25, 2019

@kumar303 would you mind to give a quick review to 783ec5c? (just a couple of small changes to the node scripts to workaround #1739)

Copy link
Contributor

@kumar303 kumar303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

This looks good to me. Skipping coverage on windows seems fine since code coverage isn't really platform specific.

Did you mean to add these changes to this exact PR? I suggest making them against master in a new PR or at least adjusting the PR title so it will be easier to find later if needed.

Also, are these code coverage instructions up to date? https://github.com/mozilla/web-ext/blob/master/CONTRIBUTING.md#code-coverage

@rpl
Copy link
Member

rpl commented Oct 28, 2019

Did you mean to add these changes to this exact PR? I suggest making them against master in a new PR or at least adjusting the PR title so it will be easier to find later if needed.

@kumar303 yeah, that was a bit lazy of me, I'm moving the fix into its own separate PR (#1742) and then I'll leave renovatebot to take this one back under its management and rebase it on top of the fix.

Also, are these code coverage instructions up to date? https://github.com/mozilla/web-ext/blob/master/CONTRIBUTING.md#code-coverage

Good point, I've actually opted to do the opposite (and make sure that the test and start npm scripts are still working as documented in the contributing markdown file).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants